Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#617 - Persistent Data Store #652

Closed
wants to merge 6 commits into from
Closed

#617 - Persistent Data Store #652

wants to merge 6 commits into from

Conversation

kdetry
Copy link
Contributor

@kdetry kdetry commented Feb 21, 2024 •
edited
Loading

Fixes #617

Changes proposed in this PR:

  • Implement a base class for DuckDB
  • Implement a child class called as "PersistentDataStore" for wrapping duckdb persistent databases
  • Implement core methods: create_view, insert_to_table, query_data
  • Create test coverage

Persistent Data Store

  • _create_and_fill_table
  • insert_to_table(self, df: pl.DataFrame, dataset_identifier: str)
  • query_data
  • fill_from_the_csv_destination
  • update_data
  • drop_table

@kdetry kdetry changed the title issue-617 Base Class issue-617 Persistent Data Store Feb 21, 2024
@kdetry kdetry changed the title issue-617 Persistent Data Store #617 - Persistent Data Store Feb 21, 2024
@idiom-bytes idiom-bytes mentioned this pull request Feb 26, 2024
Closed
5 tasks
@kdetry
Copy link
Contributor Author

kdetry commented Mar 1, 2024

I am going to merge the Issue681 branch into this branch, to prevent conflicts

@kdetry kdetry marked this pull request as draft March 1, 2024 09:35
@kdetry kdetry changed the base branch from main to issue681 March 4, 2024 15:57
@kdetry
Copy link
Contributor Author

kdetry commented Mar 4, 2024

We merged it at a middle PR with other related issues:
#734

@kdetry kdetry closed this Mar 4, 2024
@kdetry kdetry deleted the issue617 branch March 6, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KatunaNorbert KatunaNorbert Awaiting requested review from KatunaNorbert

@idiom-bytes idiom-bytes Awaiting requested review from idiom-bytes

@calina-c calina-c Awaiting requested review from calina-c

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lake] DuckDB - PersistentDataStore
1 participant
@kdetry